Skip to content

feat(driver): add AList v3 #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PIKACHUIM merged 4 commits into from
Dec 8, 2025
Merged

feat(driver): add AList v3 #1721

PIKACHUIM merged 4 commits into from
Dec 8, 2025

Conversation

@KirCute
Copy link
Member

@KirCute KirCute commented Nov 27, 2025 •
edited
Loading

Description / 描述

我干了什么：

  1. 复制drivers/openlist到drivers/alist_v3，修改结构体OpenList的名称为AListV3，修改 package 名称，修改 meta 中的驱动名称，在all.go中引入alist_v3 package
  2. 修改MeResp.Role的类型为[]int，修改Init函数判断身份的方法
  3. Revert feat(archive): support non-overwrite decompress #1701

Motivation and Context / 背景

How Has This Been Tested? / 测试

Checklist / 检查清单

  • I have read the CONTRIBUTING document.
    我已阅读 CONTRIBUTING 文档。
  • I have formatted my code with go fmt or prettier.
    我已使用 go fmt 或 prettier 格式化提交的代码。
  • I have added appropriate labels to this PR (or mentioned needed labels in the description if lacking permissions).
    我已为此 PR 添加了适当的标签（如无权限或需要的标签不存在，请在描述中说明，管理员将后续处理）。
  • I have requested review from relevant code authors using the "Request review" feature when applicable.
    我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
  • I have updated the repository accordingly (If it’s needed).
    我已相应更新了相关仓库（若适用）。

@KirCute KirCute requested a review from jyxjjj November 27, 2025 08:15
xrgzs
xrgzs previously approved these changes Nov 27, 2025
View reviewed changes
@KirCute KirCute changed the title feat(driver/openlist): compatible with AList v3 feat(driver): add AList v3 Nov 27, 2025
@KirCute KirCute requested a review from xrgzs November 27, 2025 09:39
@jyxjjj
Copy link
Member

jyxjjj commented Nov 27, 2025

我觉得可能要等1701问题研究清楚而不是直接撤回比较好？
而且我一直提倡一事一PR的，实在要撤回也建议单独撤回。

@KirCute
Copy link
Member Author

KirCute commented Nov 27, 2025 •
edited
Loading

我觉得可能要等1701问题研究清楚而不是直接撤回比较好？
而且我一直提倡一事一PR的，实在要撤回也建议单独撤回。

我不是直接把1701撤了，我指的是，把alistv3驱动里，1701改的openlist那部分代码改回去了，指的是那个overwrite，openlist驱动里的代码我没动

这个overwrite是openlist独有的功能，alist没有

@j2rong4cn
Copy link
Member

j2rong4cn commented Nov 28, 2025

徒增维护成本

@j2rong4cn
Copy link
Member

j2rong4cn commented Nov 28, 2025

可以在drivers\openlist\meta.go里多注册一个Alist v3，像quark_uc那样

@KirCute
Copy link
Member Author

KirCute commented Nov 28, 2025 •
edited
Loading

可以在drivers\openlist\meta.go里多注册一个Alist v3，像quark_uc那样

拆成两个驱动是 @PIKACHUIM 的意思，其实我觉得也有一定道理，写在一起的话后面如果 API 改了，这个驱动就只能写很多if来区分挂的是openlist还是alist，还不如早点就拆开

换成不拆可以考虑直接 reset 到 90f3f80

@PIKACHUIM PIKACHUIM merged commit 9ed77a5 into OpenListTeam:main Dec 8, 2025
12 checks passed
@KirCute KirCute deleted the feat/alist branch December 8, 2025 14:26
@BrewTestBot BrewTestBot mentioned this pull request Jan 1, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PIKACHUIM PIKACHUIM PIKACHUIM approved these changes

@jyxjjj jyxjjj Awaiting requested review from jyxjjj

@xrgzs xrgzs Awaiting requested review from xrgzs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KirCute @jyxjjj @j2rong4cn @xrgzs @PIKACHUIM